On 9/15/20 6:44 PM, Vladimir Sementsov-Ogievskiy wrote: > This is the only coroutine wrapper from block.c and block/io.c which > doesn't return a value, so let's convert it to the common behavior, to > simplify moving to generated coroutine wrappers in a further commit. > > Also, bdrv_invalidate_cache is a void function, returning error only > through **errp parameter, which is considered to be bad practice, as > it forces callers to define and propagate local_err variable, so > conversion is good anyway. > > This patch leaves the conversion of .bdrv_co_invalidate_cache() driver > callbacks and bdrv_invalidate_cache_all() for another day. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> > Reviewed-by: Eric Blake <ebl...@redhat.com> > --- > include/block/block.h | 2 +- > block.c | 32 ++++++++++++++++++-------------- > 2 files changed, 19 insertions(+), 15 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
