On 12.10.20 14:27, Philippe Mathieu-Daudé wrote: > From: Daniel P. Berrangé <berra...@redhat.com> > > The bdrv_all_*_snapshot functions return a BlockDriverState pointer > for the invalid backend, which the callers then use to report an > error message. In some cases multiple callers are reporting the > same error message, but with slightly different text. In the future > there will be more error scenarios for some of these methods, which > will benefit from fine grained error message reporting. So it is > helpful to push error reporting down a level. > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> > [PMD: Initialize variables] > Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> > --- > include/block/snapshot.h | 14 +++---- > block/monitor/block-hmp-cmds.c | 7 ++-- > block/snapshot.c | 77 +++++++++++++++++----------------- > migration/savevm.c | 37 +++++----------- > monitor/hmp-cmds.c | 7 +--- > replay/replay-debugging.c | 4 +- > tests/qemu-iotests/267.out | 10 ++--- > 7 files changed, 67 insertions(+), 89 deletions(-)
Reviewed-by: Max Reitz <mre...@redhat.com>
