Am 16.10.2020 um 19:10 hat Vladimir Sementsov-Ogievskiy geschrieben: > qcow2_do_open correctly sets errp on each failure path. So, we can > simplify code in qcow2_co_invalidate_cache() and drop explicit error > propagation.
qcow2_update_options_prepare() can return -EINVAL without setting errp: if (s->crypt_method_header != QCOW_CRYPT_NONE && !r->crypto_opts) { ret = -EINVAL; goto fail; } This is called indirectly from qcow2_do_open(). Kevin