Le 20/10/2020 à 09:36, Chenqun (kuhn) a écrit : > Ping! > > Hello, > > Maybe this patch, some people have any other suggestions? Or, maybe > missed to queue?
Hi, As we've seen by reviewing previous versions, this change is not really trivial, so I will not take it via the trivial queue. Perhaps via block I/O queue (Stefan?), Dirty Bitmaps (John?) or Migration (Juan?). Thanks, Laurent > Thanks, > Chen Qun > >> -----Original Message----- >> From: Vladimir Sementsov-Ogievskiy [mailto:vsement...@virtuozzo.com] >> Sent: Wednesday, October 14, 2020 11:56 PM >> To: Chenqun (kuhn) <kuhn.chen...@huawei.com>; qemu-de...@nongnu.org; >> qemu-triv...@nongnu.org >> Cc: mre...@redhat.com; stefa...@redhat.com; f...@euphon.net; >> ebl...@redhat.com; js...@redhat.com; quint...@redhat.com; >> dgilb...@redhat.com; Zhanghailiang <zhang.zhanghaili...@huawei.com>; >> ganqixin <ganqi...@huawei.com>; qemu-block@nongnu.org; Euler Robot >> <euler.ro...@huawei.com>; Laurent Vivier <laur...@vivier.eu>; Li Qiang >> <liq...@gmail.com> >> Subject: Re: [PATCH v3] migration/block-dirty-bitmap: fix uninitialized >> variable >> warning >> >> 14.10.2020 14:44, Chen Qun wrote: >>> A default value is provided for the variable 'bitmap_name' to avoid compiler >> warning. >>> >>> The compiler show warning: >>> migration/block-dirty-bitmap.c:1090:13: warning: ‘bitmap_name’ >>> may be used uninitialized in this function [-Wmaybe-uninitialized] >>> g_strlcpy(s->bitmap_name, bitmap_name, >> sizeof(s->bitmap_name)); >>> >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> >>> Reported-by: Euler Robot<euler.ro...@huawei.com> >>> Signed-off-by: Chen Qun<kuhn.chen...@huawei.com> >> >> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> >> >> -- >> Best regards, >> Vladimir
