On 10/23/20 1:36 PM, Eric Blake wrote: > v4 was here: > https://lists.gnu.org/archive/html/qemu-devel/2020-10/msg02708.html > > Since then: > - rebase to master > - patches 1, 2, and 12 are new based on Vladimir's observation of > QAPI_LIST_ADD > - patches 10-11 are new based on prior discussion on exposing actual > depth in addition to a tri-state encoding > - patch 3 has a nasty bug fixed that was causing iotest failures > - patch 6 updated to take advantage of patch 2 > - other minor tweaks based on review comments > > 001/12:[down] 'qapi: Move GenericList to qapi/util.h' > 002/12:[down] 'qapi: Make QAPI_LIST_ADD() public' > 003/12:[0002] [FC] 'nbd: Utilize QAPI_CLONE for type conversion' > 004/12:[0010] [FC] 'nbd: Add new qemu:allocation-depth metadata context' > 005/12:[----] [--] 'nbd: Add 'qemu-nbd -A' to expose allocation depth' > 006/12:[0014] [FC] 'nbd: Update qapi to support exporting multiple bitmaps' > 007/12:[----] [--] 'nbd: Simplify qemu bitmap context name' > 008/12:[----] [--] 'nbd: Refactor counting of metadata contexts' > 009/12:[0017] [FC] 'nbd: Allow export of multiple bitmaps for one device' > 010/12:[down] 'block: Return depth level during bdrv_is_allocated_above' > 011/12:[down] 'nbd: Expose actual depth in qemu:allocation-depth' > 012/12:[down] 'qapi: Use QAPI_LIST_ADD() where possible'
and I meant to add: Also available at: https://repo.or.cz/qemu/ericb.git/shortlog/refs/tags/nbd-alloc-depth-v5 patch 12 is the largest; it may be worth splitting that by maintainer, or even pushing it off post-5.2. Logically, it can go in anywhere after patch 2, but by putting it last, I'm hoping to send a pull request for soft freeze next week for patches 1-11 for sure, and only include 12 if we get enough positive review in time. I did not try to see if Coccinelle could make the work done in patch 12 more automatable. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org