On 17.12.20 17:19, Markus Armbruster wrote:
create_dynamic_disk() takes a buffer holding the footer as first
argument. It writes out the footer (512 bytes), then reuses the
buffer to initialize and write out the dynamic header (1024 bytes),
then reuses it again to initialize and write out BAT sectors (512).
Works, because the caller passes a buffer that is large enough for all
three purposes. I hate that.
Use a separate buffer for writing out BAT sectors. The next commit
will do the same for the dynamic header.
Signed-off-by: Markus Armbruster <arm...@redhat.com>
---
block/vpc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
(Still wondering about whether such buffers should go on the stack, but:)
Reviewed-by: Max Reitz <mre...@redhat.com>
