On Mon, 4 Jan 2021 at 17:49, Paolo Bonzini <pbonz...@redhat.com> wrote: > On 04/01/21 16:19, Peter Maydell wrote: > > Does this work recursively? For instance monitor/qmp-cmds.c > > needs the gnutls CFLAGS because: > > * qmp-cmds.c includes ui/vnc.h > > * ui/vnc.h includes include/crypto/tlssession.h > > * include/crypto/tlssession.h includes gnutls.h > > > > I don't see anything in monitor/meson.build that says "qmp-cmds.c > > needs whatever ui's dependencies are". > > Hmm, I would have thought it would be handled, but Roman said otherwise. > I'll look into it, at worst we can fix Meson and temporarily apply > Roman's patch until it makes it into a release.
NB that for qmp-cmds.c in particular https://patchew.org/QEMU/20210104161200.15068-1-peter.mayd...@linaro.org/ will avoid the accidental inclusion of <gnutls.h>, though I guess in principle the monitor still needs to say it depends on ui... thanks -- PMM
