On Dec 9 10:57, Klaus Jensen wrote: > Hi Dmitry, > > By and large, this looks OK to me. There are still some issues here and > there, and some comments of mine that you did not address, but I will > follow up with patches to fix that. Let's get this merged. > > It looks like the nvme-next you rebased on is slightly old and missing > two commits: > > "hw/block/nvme: remove superfluous NvmeCtrl parameter" and > "hw/block/nvme: pull aio error handling" > > It caused a couple of conflicts, but nothing that I couldn't fix up. > > Since I didn't manage to convince anyone about the zsze and zcap > parameters being in terms of LBAs, I'll revert that to be > 'zoned.zone_size' and 'zoned.zone_capacity'. > > Finally, would you accept that we skip "hw/block/nvme: Add injection of > Offline/Read-Only zones" for now? I'd like to discuss it a bit since I > think the random injects feels a bit ad-hoc. Back when I did OCSSD > emulation with Hans, we did something like this for setting up state > through a descriptor text file - I think we should explore something > like that before we lock down the two parameters. I'll amend the final > documentation commit to not include those parameters. > > Sounds good? > > Otherwise, I think this is mergeable to nvme-next. So, for the series > (excluding "hw/block/nvme: Add injection of Offline/Read-Only zones"): > > Reviewed-by: Klaus Jensen <k.jen...@samsung.com> >
I've applied this series to my local nvme-next. Our repo host is unavailable this morning (infradead.org), but I will push as soon as possible. Thanks! Klaus
signature.asc
Description: PGP signature