On 1/13/21 7:16 AM, Markus Armbruster wrote: > Eric Blake <ebl...@redhat.com> writes: > >> The easiest spots to use QAPI_LIST_APPEND are where we already have an >> obvious pointer to the tail of a list. While at it, consistently use >> the variable name 'tail' for that purpose. >> >> Signed-off-by: Eric Blake <ebl...@redhat.com>
>> -void acpi_cpu_ospm_status(CPUHotplugState *cpu_st, ACPIOSTInfoList ***list) >> +void acpi_cpu_ospm_status(CPUHotplugState *cpu_st, ACPIOSTInfoList ***tail) >> { >> int i; > > Sure you want to rename the parameter? What about: > > void acpi_cpu_ospm_status(CPUHotplugState *cpu_st, ACPIOSTInfoList ***list) > { > + ACPIOSTInfoList ***tail = list; > int i; Reasonable. I'll pick it up for v4. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org