Am 13.01.2021 um 16:26 hat Max Reitz geschrieben: > On 13.01.21 15:38, Kevin Wolf wrote: > > Am 13.01.2021 um 15:06 hat Max Reitz geschrieben: > > > - pylint and mypy complain. > > > (Running mypy with the options given in 297.) > > > [Patch 4 removes one pylint complaint; patch 7 the rest.] > > > > Should we add it to 297 then to make sure we won't regress? > > Sounds like a good precedent to set indeed. > > > At some point, I guess we'll want to cover all Python tests, but I > > assume it was too much to change in the same series as for the > > iotests.py cleanup. > Originally, I hadn’t intended to write patch 7 at all; I just wanted to see > what pylint/mypy said to my changes in this series, but then they made me > aware of pre-existing litter. I thought adding patch 7 would be the right > thing to do, so I did. > > (That’s to say so far I had no intentions of cleaning up all Python tests. > It’s just coincidence that I did so for 129.)
Indeed, and I wasn't trying to imply that you should, but just making a guess why we cover iotests.py and nothing else so far. Cleaning up 129 is a nice side effect of this series. If more such side effects accumulate and the rest becomes small enough, I might eventually just convert the rest. Or I might not, who knows. Kevin