On 1/15/21 8:07 AM, Klaus Jensen wrote: > On Jan 12 14:20, Philippe Mathieu-Daudé wrote: >> On 1/12/21 1:47 PM, Klaus Jensen wrote: >>> From: Klaus Jensen <k.jen...@samsung.com> >>> >>> Commit 1c0c2163aa08 ("hw/block/nvme: verify msix_init_exclusive_bar() >>> return value") had the unintended effect of breaking support on >>> several platforms not supporting MSI-X. >>> >>> Still check for errors, but only report that MSI-X is unsupported >>> instead of bailing out. >>>
BTW maybe worth adding: Cc: qemu-sta...@nongnu.org So this patch get backported in the next stable release based on 5.2. >>> Reported-by: Guenter Roeck <li...@roeck-us.net> >>> Fixes: 1c0c2163aa08 ("hw/block/nvme: verify msix_init_exclusive_bar() >>> return value") >>> Fixes: fbf2e5375e33 ("hw/block/nvme: Verify msix_vector_use() returned >>> value") >>> Signed-off-by: Klaus Jensen <k.jen...@samsung.com> >>> --- >>> hw/block/nvme.c | 31 ++++++++++++++++++++++--------- >>> 1 file changed, 22 insertions(+), 9 deletions(-) >> >> Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> >> > > Thanks! Applied to nvme-next. >