On 2/11/21 8:26 AM, Philippe Mathieu-Daudé wrote: > We are going to switch the 'null-co' default 'read-zeroes' value > from FALSE to TRUE in the next commit. First explicit the FALSE > value when it is not set. > > Suggested-by: Eric Blake <ebl...@redhat.com> > Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> > ---
> +++ b/tests/qemu-iotests/300 > @@ -44,12 +44,12 @@ class TestDirtyBitmapMigration(iotests.QMPTestCase): > def setUp(self) -> None: > self.vm_a = iotests.VM(path_suffix='-a') > self.vm_a.add_blockdev(f'node-name={self.src_node_name},' > - 'driver=null-co') > + 'driver=null-co,read-zeroes=off') > self.vm_a.launch() > > self.vm_b = iotests.VM(path_suffix='-b') > self.vm_b.add_blockdev(f'node-name={self.dst_node_name},' > - 'driver=null-co') > + 'driver=null-co,read-zeroes=off') > self.vm_b.add_incoming(f'unix:{mig_sock}') > self.vm_b.launch() > > Incomplete: 300 has a couple more lines that look like: tests/qemu-iotests/300- result = self.vm_a.qmp('blockdev-add', tests/qemu-iotests/300: node_name='node-b', driver='null-co') -- tests/qemu-iotests/300- result = self.vm_b.qmp('blockdev-add', tests/qemu-iotests/300: node_name='node-a', driver='null-co') that could use the same treatment (noticed while reviewing Peter's patch to add yet more uses in that test). -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org