On 2/15/21 7:27 PM, John Snow wrote:
On 2/15/21 1:50 PM, Wainer dos Santos Moschetta wrote:
In qtest.QEMUQtestMachine.__init__(), the argument named 'test_dir'
still make sense, right?
- Wainer
It might upset pylint/mypy to rename parameters in the initializer for
a parent class. If we rename it in the base class, we should rename it
in the descendants, too.
(I say "might" because I have not yet worked out under the exact
conditions that mypy will give you LSP warnings for initializer
methods. It definitely doesn't always seem to, but I have run afoul of
it enough times that I try to avoid it as a matter of habit now.)
Thanks for the explanation, John!
So Cleber just got another:
Reviewed-by: Wainer dos Santos Moschetta <waine...@redhat.com>
