Patchew URL: https://patchew.org/QEMU/20210219085148.90545-1-akihiko.od...@gmail.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210219085148.90545-1-akihiko.od...@gmail.com Subject: [PATCH] block/file-posix: Optimize for macOS === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20210219085148.90545-1-akihiko.od...@gmail.com -> patchew/20210219085148.90545-1-akihiko.od...@gmail.com Switched to a new branch 'test' 455b4a3 block/file-posix: Optimize for macOS === OUTPUT BEGIN === WARNING: architecture specific defines should be avoided #90: FILE: block/file-posix.c:2133: +#if defined(__APPLE__) && (__MACH__) ERROR: suspect code indent for conditional statements (8, 11) #141: FILE: hw/block/block.c:73: + if (!backend_ret && blocksizes.phys) { conf->physical_block_size = blocksizes.phys; total: 1 errors, 1 warnings, 129 lines checked Commit 455b4a328821 (block/file-posix: Optimize for macOS) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210219085148.90545-1-akihiko.od...@gmail.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
