Re: [PATCH v3 5/5] tests/fp/fp-test: Replace the word 'blacklist'

[Thomas Huth]

On 03/03/2021 19.46, Philippe Mathieu-Daudé wrote:

Follow the inclusive terminology from the "Conscious Language in your
Open Source Projects" guidelines [*] and replace the word "blacklist"
appropriately.

[*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md

Acked-by: Alex Bennée <alex.ben...@linaro.org>
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com>
---
  tests/fp/fp-test.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/fp/fp-test.c b/tests/fp/fp-test.c
index 06ffebd6db1..5a4cad8c8b2 100644
--- a/tests/fp/fp-test.c
+++ b/tests/fp/fp-test.c
@@ -123,7 +123,7 @@ static void not_implemented(void)
      fprintf(stderr, "Not implemented.\n");
  }

-static bool blacklisted(unsigned op, int rmode)

+static bool is_allowed(unsigned op, int rmode)
  {
      /* odd has not been implemented for any 80-bit ops */
      if (rmode == softfloat_round_odd) {
@@ -161,10 +161,10 @@ static bool blacklisted(unsigned op, int rmode)
          case F32_TO_EXTF80:
          case F64_TO_EXTF80:
          case F128_TO_EXTF80:
-            return true;
+            return false;
          }
      }
-    return false;
+    return true;
  }

static void do_testfloat(int op, int rmode, bool exact)

@@ -194,7 +194,7 @@ static void do_testfloat(int op, int rmode, bool exact)
      verCases_writeFunctionName(stderr);
      fputs("\n", stderr);

- if (blacklisted(op, rmode)) {

+    if (!is_allowed(op, rmode)) {
          not_implemented();
          return;
      }

Reviewed-by: Thomas Huth <th...@redhat.com>