07.04.2021 14:42, Roman Kagan wrote:
On Wed, Apr 07, 2021 at 01:46:26PM +0300, Vladimir Sementsov-Ogievskiy wrote:
The field is used only to free it. Let's drop it for now for
simplicity.
Well, it's *now* (after your patch 2) only used to free it. This makes
the reconnect process even further concealed from the user: the client
may be struggling to re-establish the connection but you'll never know
when looking at the logs.
As I wrote in my comment to patch 2 I believe these errors need to be
logged. Whether to do it directly in the reconnection thread or punt it
to the spawner of it is another matter; I'd personally prefer to do
logging in the original bdrv context as it allows to (easier) tag the
log messages with the indication of which connection is suffering.
I see your point. It may be more reasonable to rebase my series on your patch
and just save the err. Could you send your patch based on master?
--
Best regards,
Vladimir
