On 4/14/21 10:02 PM, Stefan Hajnoczi wrote: > It can be difficult to debug issues with BHs in production environments. > Although BHs can usually be identified by looking up their ->cb() > function pointer, this requires debug information for the program. It is > also not possible to print human-readable diagnostics about BHs because > they have no identifier. > > This patch adds a name to each BH. The name is not unique per instance > but differentiates between cb() functions, which is usually enough. It's > done by changing aio_bh_new() and friends to macros that stringify cb. > > The next patch will use the name field when reporting leaked BHs. > > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > --- > include/block/aio.h | 31 ++++++++++++++++++++++++++++--- > include/qemu/main-loop.h | 4 +++- > tests/unit/ptimer-test-stubs.c | 2 +- > util/async.c | 9 +++++++-- > util/main-loop.c | 4 ++-- > 5 files changed, 41 insertions(+), 9 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
