Am 17.03.2021 um 15:34 hat Vladimir Sementsov-Ogievskiy geschrieben: > We have too much comments for this feature. It seems better just don't > do it. Most of real users (tests don't count) have to create additional > reference. > > Drop also comment in external_snapshot_prepare: > - bdrv_append doesn't "remove" old bs in common sense, it sounds > strange > - the fact that bdrv_append can fail is obvious from the context > - the fact that we must rollback all changes in transaction abort is > known (it's the direct role of abort) > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>
test_append_greedy_filter() is new since v2 and needs an additional bdrv_unref() now, too. Kevin
