Am 17.03.2021 um 15:34 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all! > > Finally, I finished v3. Phew. > > Missed a soft-freeze. Should we consider it a bugfix? There are bugfixes > here but they are mostly theoretical. So, up to Kevin, should it go to > current release or to the next.. > > The main point of the series is fixing some permission update problems > (see patches 01-03 as examples), that in turn makes possible more clean > inserting and removing of filters (see patch 26 where .active field is > dropped finally from backup-top filter, we don't need a workaround > anymore). > > The series brings util/transactions.c (patch 10) and use of it in > block.c, which allows clean block graph change transactions, with > possibility of reverting all modifications (movement and removement of > children, changing aio context, changing permissions) in reverse order > on failure path. > > The series also helps Alberto's "Allow changing bs->file on reopen" > which we want to merge prior dropping x- prefix from blockdev-reopen > command.
Ok, I made it through the whole series. Looking quite good, I just had some minor comments, but maybe not quite trival enough to just fix them up while applying. I had comments on patches 1, 4, 8, 18 and 22. With these addressed, you can add to all patches in the whole series: Reviewed-by: Kevin Wolf <kw...@redhat.com> v4 should then be the final version. :-) Kevin