On 4/28/21 1:25 PM, Philippe Mathieu-Daudé wrote: > On 4/28/21 9:57 AM, Mark Cave-Ayland wrote:
>> This basically looks good to me. You may be able to simplify this >> further by removing the global legacy init functions >> fdctrl_init_sysbus() and sun4m_fdctrl_init(): from what I can see >> fdctrl_init_sysbus() is only used in hw/mips/jazz.c and >> sun4m_fdctrl_init() is only used in hw/sparc/sun4m.c so you might as >> well inline them or move the functions to the relevant files. > > But both use FDCtrlSysBus which this series makes local to > hw/block/fdc-sysbus.c, and use fdctrl_init_drives() which is declared in > hw/block/fdc-internal.h, and use FloppyBus (also declared there). > > Apparently they do that to initialize the fdctrl->dma_chann field... > Which should be a property, but FDCtrl isn't QOM... So not that > easy, it requires more work. Hmm FDCtrl doesn't have to be a QOM object, it is a simple embedded structure. It should be doable then.
