On 04.05.21 10:25, Vladimir Sementsov-Ogievskiy wrote:
bdrv_write_threshold_exceeded() is unused at all.

bdrv_write_threshold_is_set() is used only to double check the value of
bs->write_threshold_offset in tests. No real sense in it (both tests do
check real value with help of bdrv_write_threshold_get())

Well, depends on how one sees it. One could also say that it neatly hides the fact that a threshold of 0 means disabled (i.e. the overloaded meaning of the write_threshold_offset attribute).

*shrug*

Reviewed-by: Max Reitz <mre...@redhat.com>

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>
---
  include/block/write-threshold.h   | 24 ------------------------
  block/write-threshold.c           | 19 -------------------
  tests/unit/test-write-threshold.c |  4 ----
  3 files changed, 47 deletions(-)


Reply via email to