On 5/12/21 5:46 PM, John Snow wrote:
gitlab CI: https://gitlab.com/jsnow/qemu/-/pipelines/301924893 branch: https://gitlab.com/jsnow/qemu/-/commits/python-package-pre-cleanupThis series serves as a pre-requisite for packaging the python series and getting the linters running via CI. The first patch fixes a linter error we've had for a while now; the subsequent 9 fix a new warning that was recently added to pylint 2.8.x. If there's nobody opposed, I'll take it through my Python queue, including the iotests bits. John Snow (10): python/console_socket: avoid one-letter variable python/machine: use subprocess.DEVNULL instead of open(os.path.devnull) python/machine: use subprocess.run instead of subprocess.Popen python/console_socket: Add a pylint ignore python/machine: Disable pylint warning for open() in _pre_launch python/machine: disable warning for Popen in _launch() iotests: use subprocess.run where possible iotests: use 'with open()' where applicable iotests: silence spurious consider-using-with warnings iotests: ensure that QemuIoInteractive definitely closes python/qemu/console_socket.py | 11 ++++--- python/qemu/machine.py | 28 ++++++++++------ tests/qemu-iotests/iotests.py | 55 +++++++++++++++++++------------- tests/qemu-iotests/testrunner.py | 1 + 4 files changed, 57 insertions(+), 38 deletions(-)
The iotests stuff was handled by Emanuele Giuseppe Esposito instead, and -- I must admit -- better than I did. Dropping patches 7-10.
--js
