On Tue, Jun 01, 2021 at 05:59:10PM +0200, Kevin Wolf wrote: > > +++ b/block/block-backend.c > > @@ -2393,8 +2393,13 @@ static void blk_root_drained_begin(BdrvChild *child) > > static bool blk_root_drained_poll(BdrvChild *child) > > { > > BlockBackend *blk = child->opaque; > > + int ret = 0; > > It's really a bool. > > > assert(blk->quiesce_counter); > > - return !!blk->in_flight; > > + > > + if (blk->dev_ops && blk->dev_ops->drained_poll) { > > + ret = blk->dev_ops->drained_poll(blk->dev_opaque); > > + } > > + return ret || !!blk->in_flight; > > } > > Doesn't make a difference for correctness, of course, so whether you > change it or not: > > Reviewed-by: Kevin Wolf <kw...@redhat.com>
Likewise, with that cosmetic change, Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org