On Fri, Apr 16, 2021 at 11:09:02AM +0300, Vladimir Sementsov-Ogievskiy wrote: > Currently sioc pointer is used just to pass from socket-connection to > nbd negotiation. Drop the field, and use local variables instead. With > next commit we'll update nbd/client-connection.c to behave > appropriately (return only top-most ioc, not two channels). > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> > --- > block/nbd.c | 98 ++++++++++++++++++++++++++--------------------------- > 1 file changed, 48 insertions(+), 50 deletions(-) >
It's a bit hard to review 's->ioc' vs. 'sioc' when reading aloud ;) But the change looks reasonable, and I'm not spotting any memory leak in the refactoring. Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
