On Fri, Apr 16, 2021 at 11:09:10AM +0300, Vladimir Sementsov-Ogievskiy wrote: > req->receiving is a flag of request being in one concrete yield point > in nbd_co_do_receive_one_chunk(). > > Such kind of boolean flag is always better to unset before scheduling > the coroutine, to avoid double scheduling. So, let's be more careful. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> > --- > block/nbd.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >
> @@ -614,7 +616,7 @@ static int nbd_co_send_request(BlockDriverState *bs, > if (qiov) { > qio_channel_set_cork(s->ioc, true); > rc = nbd_send_request(s->ioc, request); > - if (nbd_clinet_connected(s) && rc >= 0) { > + if (nbd_client_connected(s) && rc >= 0) { Ouch - typo fix in clinet seems unrelated in this fix; please hoist it into the correct point in the series so that we don't have the typo in the first place. Otherwise, Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org