14.06.2021 11:29, Emanuele Giuseppe Esposito wrote:
There seems to be no benefit in using a field. Replace it with a local
variable, and move the state update before the yields.

The state update has do be done before the yields because now using
a local variable does not allow the new updated state to be visible
by the other yields.

Not sure that this sentence helps.. I just can't imagine how state update 
should work keeping in mind these yields :) And making state update more 
atomically makes sense to me just because it's simpler to understand.


Signed-off-by: Emanuele Giuseppe Esposito <eespo...@redhat.com>

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>



--
Best regards,
Vladimir

Reply via email to