10.08.2021 18:17, Hanna Reitz wrote:
On 04.08.21 11:37, Vladimir Sementsov-Ogievskiy wrote:
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>
---
  block/copy-before-write.h | 1 -
  block/backup.c            | 2 +-
  block/copy-before-write.c | 7 +++----
  3 files changed, 4 insertions(+), 6 deletions(-)

Well, I mean, it isn’t exactly syntactically unused before this patch; it’s 
only unused because this patch drops it from cbw_init(), too.

It definitely is functionally unused, though, so:

Reviewed-by: Hanna Reitz <hre...@redhat.com>

I wonder whether we should drop @use_copy_range and @compress from 
block_copy_state_new(), too, though.


Yes they are useless now.. I can add a patch.


--
Best regards,
Vladimir

Reply via email to