On Sep 16 09:06, Keith Busch wrote: > On Tue, Sep 14, 2021 at 10:37:26PM +0200, Klaus Jensen wrote: > > From: Klaus Jensen <k.jen...@samsung.com> > > > > Move ZNS related helpers and types into zoned.h. Use a common prefix > > (nvme_zoned or nvme_ns_zoned) for zns related functions. > > Just a nitpicks on the naming, you can feel free to ignore. > > Since we're within NVMe specific protocol here, using that terminology > should be fine. I prefer "nvme_zns_" for the prefix. > > And for function names like "nvme_zoned_zs()", the "zs" abbreviation > expands to "zone_state", so "zone" is redunant. I think > "nvme_zns_state()" is a good name for that one.
Naming is hard, so nitpicks are appreciated! I see your points, I'll fix it up :)
signature.asc
Description: PGP signature