On Fri, Sep 17, 2021 at 10:23 AM Hanna Reitz <hre...@redhat.com> wrote:
> On 17.09.21 07:40, John Snow wrote: > > This is a wrapper around the async QMPClient that mimics the old, > > synchronous QEMUMonitorProtocol class. It is designed to be > > interchangeable with the old implementation. > > > > It does not, however, attempt to mimic Exception compatibility. > > > > Signed-off-by: John Snow <js...@redhat.com> > > --- > > python/qemu/aqmp/legacy.py | 131 +++++++++++++++++++++++++++++++++++++ > > 1 file changed, 131 insertions(+) > > create mode 100644 python/qemu/aqmp/legacy.py > > Looks reasonable to me, although I can’t give an R-b in good > conscience. I’m tempted to give a neo-tag (“Looks-okay-to:”), but let’s > just be boring and do an > > Acked-by: Hanna Reitz <hre...@redhat.com> > > The mischief maker in me wants to add the custom tag, but I suppose I'll be kind to the people who crunch the stats and use the vanilla tag. :) Thanks a bunch! --js