Am 30.09.2021 um 23:28 hat John Snow geschrieben: > Hiya, I was talking this over with Hanna in review to '[PATCH v3 00/16] > python/iotests: Run iotest linters during Python CI' [1] and I have some > doubt about what you'd personally like to see happen, here. > > In a nutshell, I split out 'linters.py' from 297 and keep all of the > iotest-bits in 297 and all of the generic "run the linters" bits in > linters.py, then I run linters.py from the GitLab python CI jobs. > > I did this so that iotest #297 would continue to work exactly as it had, > but trying to serve "two masters" in the form of two test suites means some > non-beautiful design decisions. Hanna suggested we just outright drop test > 297 to possibly improve the factoring of the tests. > > I don't want to do that unless you give it the go-ahead, though. I wanted > to hear your feelings on if we still want to keep 297 around or not.
My basic requirement is that the checks are run somewhere in my local testing before I prepare a pull request. This means it could be done by iotests in any test that runs for -raw or -qcow2, or in 'make check'. So if you have a replacement somewhere in 'make check', dropping 297 is fine with me. If I have to run something entirely different, you may need to invest a bit more effort to convince me. ;-) Kevin
