On Wed, Oct 13, 2021 at 7:03 AM Hanna Reitz <hre...@redhat.com> wrote:
> On 04.10.21 23:04, John Snow wrote:
> > Instead of running "run_linters" directly, create a main() function that
> > will be responsible for environment setup, leaving run_linters()
> > responsible only for execution of the linters.
> >
> > (That environment setup will be moved over in forthcoming commits.)
> >
> > Signed-off-by: John Snow <js...@redhat.com>
> > Reviewed-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>
> > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
> > Reviewed-by: Hanna Reitz <hre...@redhat.com>
> > ---
> > tests/qemu-iotests/297 | 12 ++++++++----
> > 1 file changed, 8 insertions(+), 4 deletions(-)
> >
> > diff --git a/tests/qemu-iotests/297 b/tests/qemu-iotests/297
> > index 65b1e7058c2..f9fcb039e27 100755
> > --- a/tests/qemu-iotests/297
> > +++ b/tests/qemu-iotests/297
> > @@ -89,8 +89,12 @@ def run_linters():
> > print(p.stdout)
> >
> >
> > -for linter in ('pylint-3', 'mypy'):
> > - if shutil.which(linter) is None:
> > - iotests.notrun(f'{linter} not found')
> > +def main() -> None:
> > + for linter in ('pylint-3', 'mypy'):
> > + if shutil.which(linter) is None:
> > + iotests.notrun(f'{linter} not found')
>
> Now that I see it here: Given patch 4, shouldn’t we replace
> `shutil.which()` by some other check?
>
>
Yeah, ideally. Sorry, I was lazy and didn't do that part yet. Nobody had
asked O:-)
I'll bolster the previous patch for the next go-around. (Or maybe I'll send
a fixup patch to the list, depending on what the rest of your replies look
like.)
--js
