Signed-off-by: Emanuele Giuseppe Esposito <eespo...@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
---
  block.c                            |   3 +
  block/meson.build                  |   7 +-
  include/block/block-common.h       | 389 +++++++++++++

Can this patch be split in 3?

(first)

  include/block/block-global-state.h | 286 ++++++++++

(second)

  include/block/block-io.h           | 306 ++++++++++

(third)

I think it is a good idea especially for future patches, since it improves readability. For this series I think it has already been fully reviewed, so it won't matter too much. But I will follow this logic for the upcoming job patches, thanks.


  include/block/block.h              | 878 +----------------------------
  6 files changed, 1012 insertions(+), 857 deletions(-)
  create mode 100644 include/block/block-common.h
  create mode 100644 include/block/block-global-state.h
  create mode 100644 include/block/block-io.h

Also consider enabling scripts/git.orderfile to ease patch review.


Done, thanks for pointing it out.

Emanuele


Reply via email to