On 19.10.21 16:49, John Snow wrote:
Now, 297 is just the iotests-specific incantations and linters.py is as
minimal as I can think to make it. The only remaining element in here
that ought to be configuration and not code is the list of skip files,
but they're still numerous enough that repeating them for mypy and
pylint configurations both would be ... a hassle.
Signed-off-by: John Snow <js...@redhat.com>
---
tests/qemu-iotests/297 | 72 +++++----------------------------
tests/qemu-iotests/linters.py | 76 +++++++++++++++++++++++++++++++++++
2 files changed, 87 insertions(+), 61 deletions(-)
create mode 100644 tests/qemu-iotests/linters.py
Reviewed-by: Hanna Reitz <hre...@redhat.com>
I wonder about `check_linter()`, though. By not moving it to
linters.py, we can’t use it in its entry point, and so the Python test
infrastructure will have a strong dependency on these linters. Though
then again, it probably already does, and I suppose that’s one of the
points hindering us from running this from make check?
Hanna
