On Wed, Oct 27, 2021 at 8:56 AM Kevin Wolf <kw...@redhat.com> wrote: > Am 26.10.2021 um 19:56 hat John Snow geschrieben: > > Wait for the destination VM to close itself instead of racing to shut it > > down first, which produces different error log messages from AQMP > > depending on precisely when we tried to shut it down. > > > > (For example: We may try to issue 'quit' immediately prior to the target > > VM closing its QMP socket, which will cause an ECONNRESET error to be > > logged. Waiting for the VM to exit itself avoids the race on shutdown > > behavior.) > > > > Reported-by: Hanna Reitz <hre...@redhat.com> > > Signed-off-by: John Snow <js...@redhat.com> > > I think this will still expose the race I described in my comment on > patch 2. > > Kevin > > I wrote a long, meandering explanation of how I think things work in reply to that comment. TLDR: I didn't see the problem.
Here in reply to this comment I'll just ask: what exactly *is* the race you see happening here even with this patch? I'm not sure I see it. --js
