On 17.11.21 11:07, Thomas Huth wrote:
Hi!
I think it has been working fine for me a couple of weeks ago,
but when I now run:
make check SPEED=slow
I'm getting a couple of failing iotests... not sure whether
these are known issues already, so I thought I'd summarize them
here:
Thanks!
*** First one is 045 in raw mode: ***
TEST iotest-raw: 045 [fail]
QEMU --
"/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-system-x86_64"
-nodefaults -display none -accel qtest
QEMU_IMG --
"/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-img"
QEMU_IO --
"/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-io" --cache
writeback --aio threads -f raw
QEMU_NBD --
"/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-nbd"
IMGFMT -- raw
IMGPROTO -- file
PLATFORM -- Linux/x86_64 thuth 4.18.0-305.19.1.el8_4.x86_64
TEST_DIR -- /home/thuth/tmp/qemu-build/tests/qemu-iotests/scratch
SOCK_DIR -- /tmp/tmphlexdrlt
GDB_OPTIONS --
VALGRIND_QEMU --
PRINT_QEMU_OUTPUT --
--- /home/thuth/devel/qemu/tests/qemu-iotests/045.out
+++ 045.out.bad
@@ -1,5 +1,77 @@
-...........
+......EE.EE
+======================================================================
+ERROR: test_add_fd (__main__.TestSCMFd)
+----------------------------------------------------------------------
+Traceback (most recent call last):
+ File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 148, in
test_add_fd
+ self._send_fd_by_SCM()
+ File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 144, in
_send_fd_by_SCM
+ ret = self.vm.send_fd_scm(file_path=image0)
+ File "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line
229, in send_fd_scm
+ self._qmp.send_fd_scm(fd)
+ File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py", line 138,
in send_fd_scm
+ self._aqmp.send_fd_scm(fd)
+ File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py", line
149, in _wrapper
+ return func(proto, *args, **kwargs)
+ File "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line
644, in send_fd_scm
+ sock = sock._sock # pylint: disable=protected-access
+AttributeError: 'socket' object has no attribute '_sock'
+
+======================================================================
+ERROR: test_closefd (__main__.TestSCMFd)
+----------------------------------------------------------------------
+Traceback (most recent call last):
+ File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 165, in
test_closefd
+ self._send_fd_by_SCM()
+ File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 144, in
_send_fd_by_SCM
+ ret = self.vm.send_fd_scm(file_path=image0)
+ File "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line
229, in send_fd_scm
+ self._qmp.send_fd_scm(fd)
+ File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py", line 138,
in send_fd_scm
+ self._aqmp.send_fd_scm(fd)
+ File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py", line
149, in _wrapper
+ return func(proto, *args, **kwargs)
+ File "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line
644, in send_fd_scm
+ sock = sock._sock # pylint: disable=protected-access
+AttributeError: 'socket' object has no attribute '_sock'
+
+======================================================================
+ERROR: test_getfd (__main__.TestSCMFd)
+----------------------------------------------------------------------
+Traceback (most recent call last):
+ File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 153, in
test_getfd
+ self._send_fd_by_SCM()
+ File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 144, in
_send_fd_by_SCM
+ ret = self.vm.send_fd_scm(file_path=image0)
+ File "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line
229, in send_fd_scm
+ self._qmp.send_fd_scm(fd)
+ File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py", line 138,
in send_fd_scm
+ self._aqmp.send_fd_scm(fd)
+ File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py", line
149, in _wrapper
+ return func(proto, *args, **kwargs)
+ File "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line
644, in send_fd_scm
+ sock = sock._sock # pylint: disable=protected-access
+AttributeError: 'socket' object has no attribute '_sock'
+
+======================================================================
+ERROR: test_getfd_invalid_fdname (__main__.TestSCMFd)
+----------------------------------------------------------------------
+Traceback (most recent call last):
+ File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 158, in
test_getfd_invalid_fdname
+ self._send_fd_by_SCM()
+ File "/home/thuth/devel/qemu/tests/qemu-iotests/045", line 144, in
_send_fd_by_SCM
+ ret = self.vm.send_fd_scm(file_path=image0)
+ File "/home/thuth/devel/qemu/python/qemu/machine/machine.py", line
229, in send_fd_scm
+ self._qmp.send_fd_scm(fd)
+ File "/home/thuth/devel/qemu/python/qemu/aqmp/legacy.py", line 138,
in send_fd_scm
+ self._aqmp.send_fd_scm(fd)
+ File "/home/thuth/devel/qemu/python/qemu/aqmp/protocol.py", line
149, in _wrapper
+ return func(proto, *args, **kwargs)
+ File "/home/thuth/devel/qemu/python/qemu/aqmp/qmp_client.py", line
644, in send_fd_scm
+ sock = sock._sock # pylint: disable=protected-access
+AttributeError: 'socket' object has no attribute '_sock'
+
----------------------------------------------------------------------
Ran 11 tests
-OK
+FAILED (errors=4)
Sounds like something for John. O:)
*** Second failure is in 206 in qcow2 mode: ***
TEST iotest-qcow2: 206 [fail]
QEMU --
"/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-system-x86_64"
-nodefaults -display none -accel qtest
QEMU_IMG --
"/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-img"
QEMU_IO --
"/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-io" --cache
writeback --aio threads -f qcow2
QEMU_NBD --
"/home/thuth/tmp/qemu-build/tests/qemu-iotests/../../qemu-nbd"
IMGFMT -- qcow2
IMGPROTO -- file
PLATFORM -- Linux/x86_64 thuth 4.18.0-305.19.1.el8_4.x86_64
TEST_DIR -- /home/thuth/tmp/qemu-build/tests/qemu-iotests/scratch
SOCK_DIR -- /tmp/tmpqg73ug_s
GDB_OPTIONS --
VALGRIND_QEMU --
PRINT_QEMU_OUTPUT --
--- /home/thuth/devel/qemu/tests/qemu-iotests/206.out
+++ 206.out.bad
@@ -99,55 +99,19 @@
{"execute": "blockdev-create", "arguments": {"job-id": "job0",
"options": {"driver": "qcow2", "encrypt": {"cipher-alg":
"twofish-128", "cipher-mode": "ctr", "format": "luks", "hash-alg":
"sha1", "iter-time": 10, "ivgen-alg": "plain64", "ivgen-hash-alg":
"md5", "key-secret": "keysec0"}, "file": {"driver": "file",
"filename": "TEST_DIR/PID-t.qcow2"}, "size": 33554432}}}
{"return": {}}
+Job failed: Unsupported cipher algorithm twofish-128 with ctr mode
{"execute": "job-dismiss", "arguments": {"id": "job0"}}
{"return": {}}
image: TEST_IMG
file format: IMGFMT
virtual size: 32 MiB (33554432 bytes)
-encrypted: yes
cluster_size: 65536
Format specific information:
compat: 1.1
compression type: zlib
lazy refcounts: false
refcount bits: 16
- encrypt:
- ivgen alg: plain64
- hash alg: sha1
- cipher alg: twofish-128
- uuid: XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX
- format: luks
- cipher mode: ctr
- slots:
- [0]:
- active: true
- iters: XXX
- key offset: 4096
- stripes: 4000
- [1]:
- active: false
- key offset: 69632
- [2]:
- active: false
- key offset: 135168
- [3]:
- active: false
- key offset: 200704
- [4]:
- active: false
- key offset: 266240
- [5]:
- active: false
- key offset: 331776
- [6]:
- active: false
- key offset: 397312
- [7]:
- active: false
- key offset: 462848
- payload offset: 528384
- master key iters: XXX
corrupt: false
extended l2: false
I doubt this worked a couple of weeks ago, but it’s definitely one that
we should just get around to fixing. :/
*** Third one is in 297, both raw and qcow2 mode: ***
--- /home/thuth/devel/qemu/tests/qemu-iotests/297.out
+++ 297.out.bad
@@ -1,2 +1,21 @@
=== pylint ===
+************* Module image-fleecing
+tests/image-fleecing:34:24: C0326: Exactly one space required after
comma
+patterns = [('0x5d', '0', '64k'),
+ ^ (bad-whitespace)
+tests/image-fleecing:35:25: C0326: Exactly one space required after
comma
+ ('0xd5', '1M', '64k'),
+ ^ (bad-whitespace)
+tests/image-fleecing:36:26: C0326: Exactly one space required after
comma
+ ('0xdc', '32M', '64k'),
+ ^ (bad-whitespace)
+tests/image-fleecing:39:25: C0326: Exactly one space required after
comma
+overwrite = [('0xab', '0', '64k'), # Full overwrite
+ ^ (bad-whitespace)
+tests/image-fleecing:48:32: C0326: Exactly one space required after
comma
+remainder = [('0xd5', '0x108000', '32k'), # Right-end of
partial-left [1]
+ ^ (bad-whitespace)
+tests/image-fleecing:49:27: C0326: Exactly one space required after
comma
+ ('0xdc', '32M', '32k'), # Left-end of
partial-right [2]
+ ^ (bad-whitespace)
This could be because your pylint is too old. At least for the python/
tests we at least require 2.8.0
(https://lists.nongnu.org/archive/html/qemu-block/2021-10/msg00768.html)
and bad-whitespace was removed in 2.6.
Hanna