On Wed, Nov 17, 2021 at 04:17:07PM +0100, Hanna Reitz wrote:
> Whenever qemu-img or qemu-io report that some cipher is unsupported,
> skip the whole test, because that is probably because qemu has been
> configured with the gnutls crypto backend.
>
> We could taylor the algorithm list to what gnutls supports, but this is
> a test that is run rather rarely anyway (because it requires
> password-less sudo), and so it seems better and easier to skip it. When
> this test is intentionally run to check LUKS compatibility, it seems
> better not to limit the algorithms but keep the list extensive.
I'd really like to figure out a way to be able to partially run
this test. When I have hit problems in the past, I needed to
run specific tests, but then the expected output always contains
everything. I've thought of a few options
- Split it into many stanadlone tests - eg
tests/qemu-iotests/tests/luks-host-$ALG
- Split only the expected output eg
149-$SUBTEST
and have a way to indicate which of expected output files
we need to concatenate for the set of subtests that we
run.
- Introduce some template syntax in expected output
tha can be used to munge the output.
- Stop comparing expected output entirely and just
then this into a normal python unit test.
- Insert your idea here ?
>
> Signed-off-by: Hanna Reitz <hre...@redhat.com>
> ---
> tests/qemu-iotests/149 | 23 ++++++++++++++++++-----
> 1 file changed, 18 insertions(+), 5 deletions(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
