On Thu, Dec 16, 2021 at 5:51 AM Daniel P. Berrangé <berra...@redhat.com> wrote:
> On Wed, Dec 15, 2021 at 02:39:14PM -0500, John Snow wrote: > > GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-qmp-legacy-switch > > CI: https://gitlab.com/jsnow/qemu/-/pipelines/430491195 > > > > Hi, this series is part of an effort to publish the qemu.qmp package on > > PyPI. It is the first of three series to complete this work: > > > > --> (1) Switch the new Async QMP library in to python/qemu/qmp > > (2) Fork python/qemu/qmp out into its own repository, > > with updated GitLab CI/CD targets to build packages. > > (3) Update qemu.git to install qemu.qmp from PyPI, > > and then delete python/qemu/qmp. > > What timeframe are you suggesting step (3) for ? > > Roughly around when (2) happens; I don't want to maintain the same code in two different places. > In the series for (2) you're calling it version 0.0.1 indicating > it is liable to have API incompatible changes. > Yes. (We can pin to version 0.0.1 in-tree and bump it manually when required.) > For step (3), either we're going to have to fetch a precise > version number to avoid risk of API breakage, or we're going > to have to call it stable in (2) and commit to the API. > Pinning is what I'd prefer, I have some changes in mind that may require some API changes, so I'd rather not call it stable yet.
