Test for new option: use NBD server killing to simulate failure on file close.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> --- .../tests/blockdev-del-close-failure | 54 +++++++++++++++++++ .../tests/blockdev-del-close-failure.out | 4 ++ 2 files changed, 58 insertions(+) create mode 100755 tests/qemu-iotests/tests/blockdev-del-close-failure create mode 100644 tests/qemu-iotests/tests/blockdev-del-close-failure.out diff --git a/tests/qemu-iotests/tests/blockdev-del-close-failure b/tests/qemu-iotests/tests/blockdev-del-close-failure new file mode 100755 index 0000000000..12b442f43f --- /dev/null +++ b/tests/qemu-iotests/tests/blockdev-del-close-failure @@ -0,0 +1,54 @@ +#!/usr/bin/env python3 +# +# Test blockdev-add force=false +# +# Copyright (c) 2022 Virtuozzo International GmbH. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. +# + +import iotests +from iotests import qemu_img_create, qemu_img, qemu_nbd_popen, qemu_img_pipe + +iotests.script_initialize(supported_fmts=['qcow2'], + unsupported_imgopts=['compat']) + +disk, nbd_sock = iotests.file_path('disk', 'nbd-sock') +size = '1M' + +assert qemu_img_create('-f', iotests.imgfmt, disk, size) == 0 +assert qemu_img('bitmap', '--add', disk, 'bitmap0') == 0 +assert 'bitmaps' in qemu_img_pipe('info', disk) + +vm = iotests.VM() +vm.launch() + +with qemu_nbd_popen('-k', nbd_sock, '-f', 'raw', disk): + result = vm.qmp('blockdev-add', { + 'node-name': 'disk0', + 'driver': 'qcow2', + 'file': { + 'driver': 'nbd', + 'server': { + 'type': 'unix', + 'path': nbd_sock + } + } + }) + assert result == {'return': {}} + +# Now bitmap is loaded and marked IN_USE in the image, but connection is lost +# Bitmap can't be saved and blockdev-del(force=false) should fail +vm.qmp_log('blockdev-del', node_name='disk0', force=False) +vm.shutdown() diff --git a/tests/qemu-iotests/tests/blockdev-del-close-failure.out b/tests/qemu-iotests/tests/blockdev-del-close-failure.out new file mode 100644 index 0000000000..4a4776cc98 --- /dev/null +++ b/tests/qemu-iotests/tests/blockdev-del-close-failure.out @@ -0,0 +1,4 @@ +Start NBD server +Kill NBD server +{"execute": "blockdev-del", "arguments": {"force": false, "node-name": "disk0"}} +{"error": {"class": "GenericError", "desc": "Failed to flush node 'disk0'"}} -- 2.31.1