On Tue, 15 Feb 2022 at 17:34, Cédric Le Goater <c...@kaod.org> wrote: > > On 2/15/22 18:13, Peter Maydell wrote: > > No, as the commit message notes, it deliberately did not change > > that one vmstate, because at the time of writing the patch > > that was the one vmstate that really was still using > > load_state_old. As it happens commit 8f91aca7ff0044b hit > > master first, removing that use of load_state_old (but > > forgetting to remove the minimum_version_id_old field along > > with it), > > If I remember well, at the time of this patch, we were both working > on the same part and I thought that removing all minimum_version_id_old > in one go was better.
I would tend to disagree, but we got to the right place anyway, so it doesn't matter. I've just posted the patch that removes the load_state_old and minimum_version_id_old fields from the struct definition entirely; it's nice to be able to finally drop that little bit of legacy support. -- PMM