On Tue, Mar 8, 2022, 10:16 AM Eric Blake <ebl...@redhat.com> wrote: > On Mon, Mar 07, 2022 at 08:57:26PM -0500, John Snow wrote: > > qemu_img() returning zero ought to be the rule, not the > > exception. Remove all explicit checks against the condition in > > preparation for making non-zero returns an Exception. > > > > Signed-off-by: John Snow <js...@redhat.com> > > --- > > Reviewed-by: Eric Blake <ebl...@redhat.com> > > As this is a testsuite improvement rather than a new feature, I think > it's fine for the series to go in during soft freeze. >
Yup, I agree. I'd like to move this in sooner rather than later to guard against rot, and to have the better failure messages during testing season. I have followup patches that finish the audit of qemu-img calls. It's less clear if those should also go in during soft freeze, but I suppose I can send them and we can see how confident we feel about it. (Also note, I am giving the same treatment to qemu-io in another branch, too. That branch has revealed actual logical errors in our testing in several places. That series isn't 100% ready yet, but it might also qualify for freeze because it fixes real test defects.) > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org > >
