On Thu, Mar 17, 2022 at 11:39 AM Hanna Reitz <hre...@redhat.com> wrote: > > On 09.03.22 04:54, John Snow wrote: > > Add configurable filters to qemu_img_log(), and re-write img_info_log() > > to call into qemu_img_log() with a custom filter instead. > > > > After this patch, every last call to qemu_img() is now guaranteed to > > either have its return code checked for zero, OR have its output > > actually visibly logged somewhere. > > > > Signed-off-by: John Snow <js...@redhat.com> > > --- > > tests/qemu-iotests/iotests.py | 13 +++++++++---- > > 1 file changed, 9 insertions(+), 4 deletions(-) > > From my POV, this is a regression because before this patch (not this > series, though, admittedly), `img_info_log()` would throw an exception > on error, and with patch 12 being as it is, it will revert to its > pre-series behavior of not throwing an exception. I prefer exceptions > to failed reference output diffs, because an exception tells me which > call failed.
Hm, yeah. I just need to figure out if *all* of the qemu_img_log() calls are safe to enforce the return code of zero on... or how many need work if I change the default behavior. Let me see what I can do. I suppose it's maybe a bit late to try and squeak any of this in for freeze, so I can roll everything back up into one big series again and send a new revision.