On Fri, Mar 18, 2022 at 04:36:46PM -0400, John Snow wrote: > Rework qemu_io() to be analogous to qemu_img(); a function that requires > a return code of zero by default unless disabled explicitly. > > Tests that use qemu_io(): > 030 040 041 044 055 056 093 124 129 132 136 148 149 151 152 163 165 205 > 209 219 236 245 248 254 255 257 260 264 280 298 300 302 304 > image-fleecing migrate-bitmaps-postcopy-test migrate-bitmaps-test > migrate-during-backup migration-permissions > > Test that use qemu_io_log(): > 242 245 255 274 303 307 nbd-reconnect-on-open > > Signed-off-by: John Snow <js...@redhat.com> > > --- > > Note: This breaks several tests at this point. I'll be fixing each > broken test one by one in the subsequent commits. We can squash them all > on merge to avoid test regressions. > > (Seems like a way to have your cake and eat it too with regards to > maintaining bisectability while also having nice mailing list patches.)
Interesting approach; it does appear to have made reviewing a bit easier, so thanks for trying it. I'll withhold actual R-b until the last squashed patch, but so far, I haven't seen anything that causes me grief other than the lack of bisectability that you already have documented how it will be addressed. [less wordy - this patch is incomplete, as advertised, but looks good] -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org