On Tue, May 17, 2022 at 01:04:56PM +0200, Klaus Jensen wrote: > On May 16 17:25, Lukasz Maniak wrote: > > On Mon, May 09, 2022 at 04:16:08PM +0200, Lukasz Maniak wrote: > > > Changes since v7: > > > - Fixed description of hw/acpi: Make the PCI hot-plug aware of SR-IOV > > > - Added description to docs: Add documentation for SR-IOV and > > > Virtualization Enhancements > > > - Added Reviewed-by and Acked-by tags > > > - Rebased on master > > > > > > Lukasz Maniak (4): > > > hw/nvme: Add support for SR-IOV > > > hw/nvme: Add support for Primary Controller Capabilities > > > hw/nvme: Add support for Secondary Controller List > > > docs: Add documentation for SR-IOV and Virtualization Enhancements > > > > > > Ćukasz Gieryk (8): > > > hw/nvme: Implement the Function Level Reset > > > hw/nvme: Make max_ioqpairs and msix_qsize configurable in runtime > > > hw/nvme: Remove reg_size variable and update BAR0 size calculation > > > hw/nvme: Calculate BAR attributes in a function > > > hw/nvme: Initialize capability structures for primary/secondary > > > controllers > > > hw/nvme: Add support for the Virtualization Management command > > > hw/nvme: Update the initalization place for the AER queue > > > hw/acpi: Make the PCI hot-plug aware of SR-IOV > > > > > > docs/system/devices/nvme.rst | 82 +++++ > > > hw/acpi/pcihp.c | 6 +- > > > hw/nvme/ctrl.c | 673 ++++++++++++++++++++++++++++++++--- > > > hw/nvme/ns.c | 2 +- > > > hw/nvme/nvme.h | 55 ++- > > > hw/nvme/subsys.c | 75 +++- > > > hw/nvme/trace-events | 6 + > > > include/block/nvme.h | 65 ++++ > > > include/hw/pci/pci_ids.h | 1 + > > > 9 files changed, 909 insertions(+), 56 deletions(-) > > > > > > -- > > > 2.25.1 > > > > > > > Hi Klaus, > > > > Should we consider this series ready to merge? > > > > Hi Lukasz and Lukasz :) > > Yes, I'm queing this up. > > I found a problem when used with SPDK introduced by the "hw/nvme: Add > support for the Virtualization Management command" patch. However, it's > not really a problem in your patch, its related to the general handling > of CSTS and CC in nvme_write_bar(). I'll follow up with a patch on top > of this series and when reviewed, I'll apply this series and that patch > to nvme-next together. >
Thank you, will do a review. > Thanks for following through on this major feature! :) We are very pleased to contribute to such an important and robust project :) Lukasz > > > Klaus