On Apr 22 06:58, Keith Busch wrote: > THe emulated controller correctly accounts for not including bit buckets > in the controller-to-host data transfer, however it doesn't correctly > account for the holes for the on-disk data offsets. > > Signed-off-by: Keith Busch <kbu...@kernel.org> > --- > hw/nvme/ctrl.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c > index 03760ddeae..5e56191d45 100644 > --- a/hw/nvme/ctrl.c > +++ b/hw/nvme/ctrl.c > @@ -6773,8 +6773,7 @@ static void nvme_init_ctrl(NvmeCtrl *n, PCIDevice > *pci_dev) > id->vwc = NVME_VWC_NSID_BROADCAST_SUPPORT | NVME_VWC_PRESENT; > > id->ocfs = cpu_to_le16(NVME_OCFS_COPY_FORMAT_0 | > NVME_OCFS_COPY_FORMAT_1); > - id->sgls = cpu_to_le32(NVME_CTRL_SGLS_SUPPORT_NO_ALIGN | > - NVME_CTRL_SGLS_BITBUCKET); > + id->sgls = cpu_to_le32(NVME_CTRL_SGLS_SUPPORT_NO_ALIGN); > > nvme_init_subnqn(n); > > -- > 2.30.2 > >
Keith, We never merged anything to fix this. I suggest we simply revert it and get rid of the code entirely until *someone* comes up with a proper fix ;) I posted a revert.
signature.asc
Description: PGP signature
