Hi On Thu, Jun 16, 2022 at 5:12 PM Paolo Bonzini <pbonz...@redhat.com> wrote: > > On 6/16/22 14:40, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > > > Hi, > > > > Here is another subset of the large "subproject(qga)"" series I intend to > > send > > soon after (https://gitlab.com/marcandre.lureau/qemu/-/commits/qga). > > Hi, > > I took a peek there and I have a question. While the configure script > has had enough of a diet that it should be possible to compile the > subprojects as standalone with relatively little effort, how do you plan > to handle things such as compiler flags that are detected by meson.build > (especially enabling/disabling warnings)? >
If you run top-level qemu configure, then I think flags should be shared with add_global_arguments() (to be verified). qemu-ga (and qemu-common) in the branch do compile standalone. There are still small quirks to fix the CI though with the last patches. Also the last patch could probably deserve a little bit more splitting (for ex, switching from QEMU_FULL_VERSION to VCS_TAG etc), that branch is still WIP (after 2 months!). > Paolo > > > Thanks > > > > Marc-André Lureau (9): > > monitor: make error_vprintf_unless_qmp() static > > error-report: misc comment fix > > error-report: introduce "detailed" variable > > error-report: simplify print_loc() > > error-report: introduce ErrorReportDetailedFunc > > error-report: add a callback to overwrite error_vprintf > > qapi: move QEMU-specific dispatch code in monitor > > scripts/qapi-gen: add -i option > > scripts/qapi: add required system includes to visitor > > > > include/monitor/monitor.h | 2 +- > > include/qapi/qmp/dispatch.h | 7 ++- > > include/qemu/error-report.h | 8 +++- > > bsd-user/main.c | 2 +- > > linux-user/main.c | 2 +- > > monitor/monitor.c | 5 +- > > monitor/qmp.c | 68 +++++++++++++++++++++++++++- > > qapi/qmp-dispatch.c | 64 ++------------------------ > > qemu-img.c | 2 +- > > qemu-io.c | 2 +- > > qemu-nbd.c | 2 +- > > qga/main.c | 2 +- > > scsi/qemu-pr-helper.c | 2 +- > > softmmu/vl.c | 7 ++- > > storage-daemon/qemu-storage-daemon.c | 7 ++- > > stubs/error-printf.c | 23 ---------- > > tests/unit/test-qmp-cmds.c | 6 +-- > > util/error-report.c | 46 ++++++++++++++----- > > scripts/qapi/commands.py | 15 ++++-- > > scripts/qapi/events.py | 17 ++++--- > > scripts/qapi/gen.py | 17 +++++++ > > scripts/qapi/introspect.py | 11 +++-- > > scripts/qapi/main.py | 17 ++++--- > > scripts/qapi/types.py | 17 ++++--- > > scripts/qapi/visit.py | 21 ++++++--- > > stubs/meson.build | 1 - > > 26 files changed, 226 insertions(+), 147 deletions(-) > > delete mode 100644 stubs/error-printf.c > > >