Am 11.08.2022 um 18:49 hat Stefan Hajnoczi geschrieben: > The gluster protocol driver used to parse URIs (filenames) but was > extended with a richer JSON syntax in commit 6c7189bb29de > ("block/gluster: add support for multiple gluster servers"). The gluster > drivers that have JSON parsing set .bdrv_needs_filename to false. > > The gluster+unix and gluster+rdma drivers still to require a filename > even though the JSON parser is equipped to parse the same > volume/path/sockaddr details as the URI parser. Let's allow JSON parsing > for these drivers too. > > Note that the gluster+rdma driver actually uses TCP because RDMA support > is not available, so the JSON server.type field must be "inet". > > Drop .bdrv_needs_filename since both the filename and the JSON parsers > can handle gluster+unix and gluster+rdma. This change is in preparation > for eventually removing .bdrv_needs_filename across the entire codebase. > > Cc: Prasanna Kumar Kalever <prasanna.kale...@redhat.com> > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
Thanks, applied to the block branch. Kevin