On Thu, Sep 29, 2022 at 07:59:50PM +0200, Kevin Wolf wrote: > Am 29.09.2022 um 18:09 hat Keith Busch geschrieben: > > On Fri, Sep 23, 2022 at 08:34:51AM -0700, Keith Busch wrote: > > > > > > An iov length needs to be aligned to the logical block size, which may > > > be larger than the memory alignment. And since this is only used with > > > file-posix backing storage, move the alignment function to there, where > > > the value of the request_alignment is known to be the file's logical > > > block size. > > > > Any objections to this version? This is fixing real bug reports that > > may become more frequent without this patch. > > I think it is okay. Splitting it in two patches would have been nicer > (one for moving code, one for making the change), but it's small enough > that I can ignore that. I'll probably merge it tomorrow.
I agree that splitting makes the functional change stand out, otherwise a casual look may mistake the patch as a simple function move. I'll send you a new version.
