Hi Marc-André, On Mon, Oct 3, 2022 at 5:26 PM Marc-André Lureau <marcandre.lur...@gmail.com> wrote: > > Hi Bin > > On Tue, Sep 27, 2022 at 3:18 PM Bin Meng <bmeng...@gmail.com> wrote: >> >> In preparation to adding virtio-9p support on Windows, this series >> enables running qtest on Windows, so that we can run the virtio-9p >> tests on Windows to make sure it does not break accidently. >> >> Changes in v4: >> - Do not use g_autofree and g_steal_pointer >> - Update the error reporting by using the GError "error" argument >> of g_dir_make_tmp() >> - Remove the const from tmpfs declaration >> - Replace the whole block with a g_assert_no_error() >> - Replace the error reporting with g_assert_no_error() >> - Update error reporting >> - Move the new text section after the "QTest" section instead >> - Use plural in both cases: "on POSIX hosts as well as Windows hosts" >> - Use "The following list shows some best practices" >> - Fix typo of delimiter >> - New patch: "tests/qtest: boot-serial-test: Close the serial file before >> starting QEMU" >> - Drop patch: "chardev/char-file: Add FILE_SHARE_WRITE when openning the >> file for win32" >> > > Could you post a v5 rebased on the current master? thanks >
Sure, will do. > (I think most of the remaining patches are simple enough that I could take > them in a misc PR if they are not picked by subsystem maintainers) Thank you. Regards, Bin