Branch: refs/heads/staging
Home: https://github.com/qemu/qemu
Commit: 4d13ae45ff93fa825ceb39dfd16b305f4baccd18
https://github.com/qemu/qemu/commit/4d13ae45ff93fa825ceb39dfd16b305f4baccd18
Author: David Hildenbrand <[email protected]>
Date: 2024-07-10 (Wed, 10 Jul 2024)
Changed paths:
M hw/virtio/virtio-mem.c
Log Message:
-----------
virtio-mem: improve error message when unplug of device fails due to plugged
memory
The error message is actually expressive, considering QEMU only. But
when called from Libvirt, talking about "size" can be confusing, because
in Libvirt "size" translates to the memory backend size in QEMU (maximum
size) and "current" translates to the QEMU "size" property.
Let's simply avoid talking about the "size" property and spell out that
some device memory is still plugged.
Message-ID: <[email protected]>
Tested-by: Mario Casquero <[email protected]>
Cc: Liang Cong <[email protected]>
Cc: Mario Casquero <[email protected]>
Cc: "Michael S. Tsirkin" <[email protected]>
Signed-off-by: David Hildenbrand <[email protected]>
Commit: 249d0f83977c71c5a392c00947e1e7d5415ac5be
https://github.com/qemu/qemu/commit/249d0f83977c71c5a392c00947e1e7d5415ac5be
Author: Nir Soffer <[email protected]>
Date: 2024-07-11 (Thu, 11 Jul 2024)
Changed paths:
M tests/qemu-iotests/245
Log Message:
-----------
qemu-iotest/245: Add missing discard=unmap
The test works since we punch holes by default even when opening the
image without discard=on or discard=unmap. Fix the test to enable
discard.
Signed-off-by: Stefan Hajnoczi <[email protected]>
Commit: d05ae948cc887054495977855b0859d0d4ab2613
https://github.com/qemu/qemu/commit/d05ae948cc887054495977855b0859d0d4ab2613
Author: Nir Soffer <[email protected]>
Date: 2024-07-11 (Thu, 11 Jul 2024)
Changed paths:
M block/io.c
A tests/qemu-iotests/tests/write-zeroes-unmap
A tests/qemu-iotests/tests/write-zeroes-unmap.out
Log Message:
-----------
Consider discard option when writing zeros
When opening an image with discard=off, we punch hole in the image when
writing zeroes, making the image sparse. This breaks users that want to
ensure that writes cannot fail with ENOSPACE by using fully allocated
images[1].
bdrv_co_pwrite_zeroes() correctly disables BDRV_REQ_MAY_UNMAP if we
opened the child without discard=unmap or discard=on. But we don't go
through this function when accessing the top node. Move the check down
to bdrv_co_do_pwrite_zeroes() which seems to be used in all code paths.
This change implements the documented behavior, punching holes only when
opening the image with discard=on or discard=unmap. This may not be the
best default but can improve it later.
The test depends on a file system supporting discard, deallocating the
entire file when punching hole with the length of the entire file.
Tested with xfs, ext4, and tmpfs.
[1] https://lists.nongnu.org/archive/html/qemu-discuss/2024-06/msg00003.html
Signed-off-by: Nir Soffer <[email protected]>
Message-id: [email protected]
Signed-off-by: Stefan Hajnoczi <[email protected]>
Commit: e359e94b1c2112a2497281df3d5219e57904818c
https://github.com/qemu/qemu/commit/e359e94b1c2112a2497281df3d5219e57904818c
Author: Richard Henderson <[email protected]>
Date: 2024-07-11 (Thu, 11 Jul 2024)
Changed paths:
M hw/virtio/virtio-mem.c
Log Message:
-----------
Merge tag 'mem-2024-07-10' of https://github.com/davidhildenbrand/qemu into
staging
Hi,
"Host Memory Backends" and "Memory devices" queue ("mem"):
- Only one error message improvement that causes less confusion when
triggered from libvirt
# -----BEGIN PGP SIGNATURE-----
#
# iQJFBAABCAAvFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmaOxu8RHGRhdmlkQHJl
# ZGhhdC5jb20ACgkQTd4Q9wD/g1pZiw//eDZBykgFbP164XEr8VfCt97gPHAUtwWQ
# fCi/MggOx3BE3V2TKCOSKSggTXrlpif3O+LziIMds9u7s5Gf7MdblMFmjvPglwXM
# pPZkJ6egNVnVJ5kTP+MHUbLyjbXayHaPIOlNupUXpn38lKd0Vn4/0jJ3XHkTUYvx
# xNP6GEomwvps5KiPtpHo+QApFluEy+ZYxexMdDPaa5wjgVECm+7s3Y9K+6EZnA3j
# 4wJCHgM91QDJ/+yu5vjNwn2rEqSf8fPjara1uVJxKYpNnYfv/7oEkuzXPL9HUING
# ARKH0rq4Yhv+2cvb5hyuQK7/XoMJ8KaKnnynqCWH8A/8/jfAQzlktT07lp5vYzHW
# 7/YivQUjZYxUBobvZLK2xNm96jDjvtRxsQqFmUi7fkLyN0qZWZC4xGQSCGbXTv/8
# t0BpyUfI6lJO2gZQFjWUc3uz3wJkucZRxC2qaNXfUf0Om99TPboafi37XM0Pgagh
# T2GiZK1x4fSGedT79+wmHyLt+RZqABouAWMqTtdppQJtMt/ZnqXcW0Z4bRQo4FX6
# ULW/ZvRmT0yguI9su0hwcLeZ8+6eTHzoCFi3yZVcWGv+Zdpnmk53G8cIkQXO3CQO
# VEw/5VfQCbdoqEu1WdM1Dil5mCf7ZOukbjWZNb4D3Sb7q001t5IZKmgkU3Iyv0oC
# V1xDpsnaevM=
# =/wCe
# -----END PGP SIGNATURE-----
# gpg: Signature made Wed 10 Jul 2024 10:37:51 AM PDT
# gpg: using RSA key 1BD9CAAD735C4C3A460DFCCA4DDE10F700FF835A
# gpg: issuer "[email protected]"
# gpg: Good signature from "David Hildenbrand <[email protected]>" [undefined]
# gpg: aka "David Hildenbrand <[email protected]>"
[full]
# gpg: aka "David Hildenbrand <[email protected]>" [unknown]
# gpg: WARNING: The key's User ID is not certified with a trusted signature!
# gpg: There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 1BD9 CAAD 735C 4C3A 460D FCCA 4DDE 10F7 00FF 835A
* tag 'mem-2024-07-10' of https://github.com/davidhildenbrand/qemu:
virtio-mem: improve error message when unplug of device fails due to plugged
memory
Signed-off-by: Richard Henderson <[email protected]>
Commit: 39a032cea23e522268519d89bb738974bc43b6f6
https://github.com/qemu/qemu/commit/39a032cea23e522268519d89bb738974bc43b6f6
Author: Richard Henderson <[email protected]>
Date: 2024-07-11 (Thu, 11 Jul 2024)
Changed paths:
M block/io.c
M tests/qemu-iotests/245
A tests/qemu-iotests/tests/write-zeroes-unmap
A tests/qemu-iotests/tests/write-zeroes-unmap.out
Log Message:
-----------
Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into
staging
Pull request
A discard fix from Nir Soffer.
# -----BEGIN PGP SIGNATURE-----
#
# iQEzBAABCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmaPoiAACgkQnKSrs4Gr
# c8hjGAf+JxwJOBibYVdyPRhnrYWu3b/G3rAfwSnYvgJrCPDztmLTB50lCDCnZ2Jr
# T/GN8/BYbuR7O2VkEEMXutrYkLWAUQNGz28wd6GgaeYL/rx7yEg5htmP2nWSySP3
# rS3ri3i30QUHI/zSOH5a5eRVQBDZECyyd7jAADqhYt6Vfh9O3ApUy8SPxS6sT7WF
# i5a8ffqDVtiFaE2nvBs8KncdRZcBkiNyWt122cvbYCLepy2G3/WD3gv/AP126xGO
# bGzBQUODCqcgbIjUH5d5qOLhB4eppqxsclHMwIZeo5QV/De5BVjg2I6LxOutdbv3
# 1MAAHFsbjLRBnKVWafgz2vCi/gi1gA==
# =hjGY
# -----END PGP SIGNATURE-----
# gpg: Signature made Thu 11 Jul 2024 02:13:04 AM PDT
# gpg: using RSA key 8695A8BFD3F97CDAAC35775A9CA4ABB381AB73C8
# gpg: Good signature from "Stefan Hajnoczi <[email protected]>" [full]
# gpg: aka "Stefan Hajnoczi <[email protected]>" [full]
* tag 'block-pull-request' of https://gitlab.com/stefanha/qemu:
Consider discard option when writing zeros
qemu-iotest/245: Add missing discard=unmap
Signed-off-by: Richard Henderson <[email protected]>
Compare: https://github.com/qemu/qemu/compare/59084feb256c...39a032cea23e
To unsubscribe from these emails, change your notification settings at
https://github.com/qemu/qemu/settings/notifications
