Branch: refs/heads/staging
Home: https://github.com/qemu/qemu
Commit: 118a2991bbeeb7ea641626d680f100f8ac6eff80
https://github.com/qemu/qemu/commit/118a2991bbeeb7ea641626d680f100f8ac6eff80
Author: Gerd Hoffmann <[email protected]>
Date: 2024-11-18 (Mon, 18 Nov 2024)
Changed paths:
M system/vl.c
Log Message:
-----------
vl: fix qemu_validate_options() indention
Signed-off-by: Gerd Hoffmann <[email protected]>
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Message-ID: <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Commit: a29a9776407e68c5560687e07828925bda710150
https://github.com/qemu/qemu/commit/a29a9776407e68c5560687e07828925bda710150
Author: Peter Maydell <[email protected]>
Date: 2024-11-18 (Mon, 18 Nov 2024)
Changed paths:
M hw/misc/nrf51_rng.c
Log Message:
-----------
hw/misc/nrf51_rng: Don't use BIT_MASK() when we mean BIT()
The BIT_MASK() macro from bitops.h provides the mask of a bit
within a particular word of a multi-word bit array; it is intended
to be used with its counterpart BIT_WORD() that gives the index
of the word in the array.
In nrf51_rng we are using it for cases where we have a bit number
that we know is the index of a bit within a single word (in fact, it
happens that all the bit numbers we pass to it are zero). This
happens to give the right answer, but the macro that actually
does the job we want here is BIT().
Use BIT() instead of BIT_MASK().
Signed-off-by: Peter Maydell <[email protected]>
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Message-ID: <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Commit: 13cd9e6798536c35949440d9fc11f54cc052fce3
https://github.com/qemu/qemu/commit/13cd9e6798536c35949440d9fc11f54cc052fce3
Author: Sergio Lopez <[email protected]>
Date: 2024-11-18 (Mon, 18 Nov 2024)
Changed paths:
M hw/i386/x86-common.c
Log Message:
-----------
hw/i386/elfboot: allocate "header" in heap
In x86_load_linux(), we were using a stack-allocated array as data for
fw_cfg_add_bytes(). Since the latter just takes a reference to the
pointer instead of copying the data, it can happen that the contents
have been overridden by the time the guest attempts to access them.
Instead of using the stack-allocated array, allocate some memory from
the heap, copy the contents of the array, and use it for fw_cfg.
Signed-off-by: Sergio Lopez <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Message-ID: <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Commit: c4e1c361b342ccff11df6748198b1e0bcad9b635
https://github.com/qemu/qemu/commit/c4e1c361b342ccff11df6748198b1e0bcad9b635
Author: Alex Bennée <[email protected]>
Date: 2024-11-18 (Mon, 18 Nov 2024)
Changed paths:
M hw/display/virtio-gpu-virgl.c
M hw/display/virtio-gpu.c
M include/hw/virtio/virtio-gpu.h
Log Message:
-----------
hw/display: factor out the scanout blob to fb conversion
There are two identical sequences of a code doing the same thing that
raise warnings with Coverity. Before fixing those issues lets factor
out the common code into a helper function we can share.
Signed-off-by: Alex Bennée <[email protected]>
Cc: Dmitry Osipenko <[email protected]>
Reviewed-by: Dmitry Osipenko <[email protected]>
Tested-by: Dmitry Osipenko <[email protected]>
Message-ID: <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Commit: 7b5574225429621e7122a83c06d1b23931f152df
https://github.com/qemu/qemu/commit/7b5574225429621e7122a83c06d1b23931f152df
Author: Alex Bennée <[email protected]>
Date: 2024-11-18 (Mon, 18 Nov 2024)
Changed paths:
M hw/display/virtio-gpu.c
M include/hw/virtio/virtio-gpu.h
Log Message:
-----------
hw/display: check frame buffer can hold blob
Coverity reports (CID 1564769, 1564770) that we potentially overflow
by doing some 32x32 multiplies for something that ends up in a 64 bit
value. Fix this by first using stride for all lines and casting input
to uint64_t to ensure a 64 bit multiply is used.
Signed-off-by: Alex Bennée <[email protected]>
Cc: Dmitry Osipenko <[email protected]>
Reviewed-by: Dmitry Osipenko <[email protected]>
Tested-by: Dmitry Osipenko <[email protected]>
Message-ID: <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Commit: fdc2294ac91c24d22ee58b12be803011a94e84c6
https://github.com/qemu/qemu/commit/fdc2294ac91c24d22ee58b12be803011a94e84c6
Author: Zhang Chen <[email protected]>
Date: 2024-11-18 (Mon, 18 Nov 2024)
Changed paths:
M MAINTAINERS
Log Message:
-----------
MAINTAINERS: Update my email address for COLO
Signed-off-by: Zhang Chen <[email protected]>
Reviewed-by: Li Zhijian <[email protected]>
Message-ID: <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Commit: b2cc69997924b651c0c6f4037782e25f2e438715
https://github.com/qemu/qemu/commit/b2cc69997924b651c0c6f4037782e25f2e438715
Author: Guenter Roeck <[email protected]>
Date: 2024-11-18 (Mon, 18 Nov 2024)
Changed paths:
M hw/usb/dev-hub.c
Log Message:
-----------
usb-hub: Fix handling port power control messages
The ClearPortFeature control message fails for PORT_POWER because there
is no break; at the end of the case statement, causing it to fall through
to the failure handler. Add the missing break; to solve the problem.
Fixes: 1cc403eb21 ("usb-hub: emulate per port power switching")
Signed-off-by: Guenter Roeck <[email protected]>
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Message-ID: <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Commit: 19e566162cbac0fd2051b31636207a3c88192e2b
https://github.com/qemu/qemu/commit/19e566162cbac0fd2051b31636207a3c88192e2b
Author: Fabiano Rosas <[email protected]>
Date: 2024-11-18 (Mon, 18 Nov 2024)
Changed paths:
M tests/qtest/migration-helpers.c
M tests/qtest/migration-test.c
Log Message:
-----------
tests/qtest/migration: Fix indentations
Select all the code and hit tab. I'll be moving functions around quite
a lot in the next patches, so make sure all indentation is correct
now.
Add parentheses around some expressions to preserve readability.
Reviewed-by: Daniel P. Berrangé <[email protected]>
Signed-off-by: Fabiano Rosas <[email protected]>
Message-ID: <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Commit: 6607b77b94c353fbe21888d216fa97df9b859f15
https://github.com/qemu/qemu/commit/6607b77b94c353fbe21888d216fa97df9b859f15
Author: Paolo Bonzini <[email protected]>
Date: 2024-11-18 (Mon, 18 Nov 2024)
Changed paths:
M target/i386/kvm/hyperv-stub.c
Log Message:
-----------
target/i386: hyperv: add stub for hyperv_syndbg_query_options
Building without CONFIG_HYPERV is currently broken due to a missing
symbol 'hyperv_syndbg_query_options'. Add it to the stubs
that exist for that very reasons.
Reported-by: Michael Tokarev <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
Commit: ebcf886d88e0fcae322d063b28846d20b23b5321
https://github.com/qemu/qemu/commit/ebcf886d88e0fcae322d063b28846d20b23b5321
Author: Akihiko Odaki <[email protected]>
Date: 2024-11-18 (Mon, 18 Nov 2024)
Changed paths:
M configure
Log Message:
-----------
configure: Use -ef to compare paths
configure checks if it is executed in the source directory by comparing
the literal paths, but there may be multiple representations of a
directory due to symbolic links. Use the -ef operator to tell if they
point to the same directory.
Signed-off-by: Akihiko Odaki <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Paolo Bonzini <[email protected]>
Commit: 2df42919569ccacb255068e5230f43060cf66dfc
https://github.com/qemu/qemu/commit/2df42919569ccacb255068e5230f43060cf66dfc
Author: Jamin Lin <[email protected]>
Date: 2024-11-18 (Mon, 18 Nov 2024)
Changed paths:
M hw/sd/sdhci.c
Log Message:
-----------
hw/sd/sdhci: Fix coding style
Fix coding style issues from checkpatch.pl
Signed-off-by: Jamin Lin <[email protected]>
Reviewed-by: Cédric Le Goater <[email protected]>
Message-ID: <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Commit: c3d7c18b0d616cf7fb3c1f325503e1462307209d
https://github.com/qemu/qemu/commit/c3d7c18b0d616cf7fb3c1f325503e1462307209d
Author: Thomas Huth <[email protected]>
Date: 2024-11-18 (Mon, 18 Nov 2024)
Changed paths:
M include/hw/misc/mos6522.h
Log Message:
-----------
hw/misc/mos6522: Fix bad class definition of the MOS6522 device
When compiling QEMU with --enable-cfi, the "q800" m68k machine
currently crashes very early, when the q800_machine_init() function
tries to wire the interrupts of the "via1" device.
This happens because TYPE_MOS6522_Q800_VIA1 is supposed to be a
proper SysBus device, but its parent (TYPE_MOS6522) has a mistake
in its class definition where it is only derived from DeviceClass,
and not from SysBusDeviceClass, so we end up in funny memory access
issues here. Using the right class hierarchy for the MOS6522 device
fixes the problem.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2675
Signed-off-by: Thomas Huth <[email protected]>
Fixes: 51f233ec92 ("misc: introduce new mos6522 VIA device")
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Reviewed-by: Mark Cave-Ayland <[email protected]>
Message-ID: <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Commit: e125d9835b89545b09c0367404dcf69f18ae6de1
https://github.com/qemu/qemu/commit/e125d9835b89545b09c0367404dcf69f18ae6de1
Author: Paolo Bonzini <[email protected]>
Date: 2024-11-18 (Mon, 18 Nov 2024)
Changed paths:
M hw/audio/hda-codec.c
Log Message:
-----------
Revert "hw/audio/hda: fix memory leak on audio setup"
This reverts commit 6d03242a7e47815ed56687ecd13f683d8da3f2fe,
which causes SPICE audio to break. While arguably this is a SPICE bug,
it is possible to fix the leak in a less heavy-handed way.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2639
Cc: [email protected]
Signed-off-by: Paolo Bonzini <[email protected]>
Reviewed-by: Michael Tokarev <[email protected]>
Message-ID: <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Commit: 626b39006d2f9b1378a04cb88a2187bb852cb055
https://github.com/qemu/qemu/commit/626b39006d2f9b1378a04cb88a2187bb852cb055
Author: Paolo Bonzini <[email protected]>
Date: 2024-11-18 (Mon, 18 Nov 2024)
Changed paths:
M hw/audio/hda-codec.c
Log Message:
-----------
hw/audio/hda: fix memory leak on audio setup
When SET_STREAM_FORMAT is called, the st->buft timer is overwritten, thus
causing a memory leak. This was originally fixed in commit 816139ae6a5
("hw/audio/hda: fix memory leak on audio setup", 2024-11-14) but that
caused the audio to break in SPICE.
Fortunately, a simpler fix is possible. The timer only needs to be
reset, because the callback is always the same (st->output is set at
realize time in hda_audio_init); call to timer_new_ns overkill. Replace
it with timer_del and only initialize the timer once; for simplicity,
do it even if use_timer is false.
An even simpler fix would be to free the old time in hda_audio_setup().
However, it seems better to place the initialization of the timer close
to that of st->ouput.
Cc: [email protected]
Signed-off-by: Paolo Bonzini <[email protected]>
Reviewed-by: Michael Tokarev <[email protected]>
Message-ID: <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Commit: 5814c08467937154745c6cb2b3400800b98ff897
https://github.com/qemu/qemu/commit/5814c08467937154745c6cb2b3400800b98ff897
Author: Peter Maydell <[email protected]>
Date: 2024-11-18 (Mon, 18 Nov 2024)
Changed paths:
M hw/net/virtio-net.c
M include/hw/virtio/virtio-net.h
Log Message:
-----------
hw/net/virtio-net.c: Don't assume IP length field is aligned
In virtio-net.c we assume that the IP length field in the packet is
aligned, and we copy its address into a uint16_t* in the
VirtioNetRscUnit struct which we then dereference later. This isn't
a safe assumption; it will also result in compilation failures if we
mark the ip_header struct as QEMU_PACKED because the compiler will
not let you take the address of an unaligned struct field.
Make the ip_plen field in VirtioNetRscUnit a void*, and make all the
places where we read or write through that pointer instead use some
new accessor functions read_unit_ip_len() and write_unit_ip_len()
which account for the pointer being potentially unaligned and also do
the network-byte-order conversion we were previously using htons() to
perform.
Signed-off-by: Peter Maydell <[email protected]>
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Message-ID: <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Commit: f8b94b4c520126ab2745dbcf0e93cf8642b127fb
https://github.com/qemu/qemu/commit/f8b94b4c520126ab2745dbcf0e93cf8642b127fb
Author: Peter Maydell <[email protected]>
Date: 2024-11-18 (Mon, 18 Nov 2024)
Changed paths:
M include/net/eth.h
Log Message:
-----------
net: mark struct ip_header as QEMU_PACKED
The ip_header is not actually guaranteed to be aligned. We attempt to
deal with this in some places such as net_checksum_calculate() by
using stw_be_p and so on to access the fields, but this is not
sufficient to be correct, because even accessing a byte member
within an unaligned struct is undefined behaviour. The clang
sanitizer will emit warnings like these if net_checksum_calculate()
is called:
Stopping network: ../../net/checksum.c:106:9: runtime error: member access
within misaligned address 0x556aad9b502e for type 'struct ip_header', which
requires 4 byte alignment
0x556aad9b502e: note: pointer points here
34 56 08 00 45 00 01 48 a5 09 40 00 40 11 7c 8b 0a 00 02 0f 0a 00 02 02
00 44 00 43 01 34 19 56
^
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
../../net/checksum.c:106:9 in
../../net/checksum.c:106:9: runtime error: load of misaligned address
0x556aad9b502e for type 'uint8_t' (aka 'unsigned char'), which requires 4 byte
alignment
0x556aad9b502e: note: pointer points here
34 56 08 00 45 00 01 48 a5 09 40 00 40 11 7c 8b 0a 00 02 0f 0a 00 02 02
00 44 00 43 01 34 19 56
^
Fix this by marking the ip_header struct as QEMU_PACKED, so that
the compiler knows that it might be unaligned and will generate
the right code for accessing fields.
Signed-off-by: Peter Maydell <[email protected]>
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Message-ID: <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Commit: b6db70bc0a9e53e7aa04cc940db1ddbee17fa700
https://github.com/qemu/qemu/commit/b6db70bc0a9e53e7aa04cc940db1ddbee17fa700
Author: Roque Arcudia Hernandez <[email protected]>
Date: 2024-11-18 (Mon, 18 Nov 2024)
Changed paths:
M hw/watchdog/cmsdk-apb-watchdog.c
Log Message:
-----------
hw/watchdog/cmsdk_apb_watchdog: Fix broken link
The patch changes the comments to point to the latest Design Kit
Technical Reference Manual.
Signed-off-by: Roque Arcudia Hernandez <[email protected]>
Tested-by: Philippe Mathieu-Daudé <[email protected]>
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Message-ID: <[email protected]>
Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
Commit: 3f4ad55ea28f75804d999cd3e1169c188bde052a
https://github.com/qemu/qemu/commit/3f4ad55ea28f75804d999cd3e1169c188bde052a
Author: Peter Maydell <[email protected]>
Date: 2024-11-18 (Mon, 18 Nov 2024)
Changed paths:
M MAINTAINERS
M hw/audio/hda-codec.c
M hw/display/virtio-gpu-virgl.c
M hw/display/virtio-gpu.c
M hw/i386/x86-common.c
M hw/misc/nrf51_rng.c
M hw/net/virtio-net.c
M hw/sd/sdhci.c
M hw/usb/dev-hub.c
M hw/watchdog/cmsdk-apb-watchdog.c
M include/hw/misc/mos6522.h
M include/hw/virtio/virtio-gpu.h
M include/hw/virtio/virtio-net.h
M include/net/eth.h
M system/vl.c
M tests/qtest/migration-helpers.c
M tests/qtest/migration-test.c
Log Message:
-----------
Merge tag 'hw-misc-20241118' of https://github.com/philmd/qemu into staging
Misc HW fixes
# -----BEGIN PGP SIGNATURE-----
#
# iQIzBAABCAAdFiEE+qvnXhKRciHc/Wuy4+MsLN6twN4FAmc7NwwACgkQ4+MsLN6t
# wN7zBA//VTiAcjB1KYovOiHQWdhtyE7JU+ZOCzULK2aDoKCP9wZM5yZVQgKbDFX/
# +bI2yjzTfZAWknxnqdShQMxvJE3PkD25mm8D2bP22/U9agKSrX4ll9pGt1NMIHUR
# Hy01gxoLYp0r/Vs0aDWVQGSU4v62hKjTNOFn30Gqg+Xu9W4glEPSwI5GicypxpWZ
# nNAl88whHZ6qouadNCSt0JghwWplw6ZkV3LU4dAUhhhRh+vkPoA3NiCCr4cNqNjJ
# yeGc6lLGf2M9GMpX3t2XEV6lXkBTdhUtdv0inZTzH8W2dYt/SL3n/nSKdddXU+fl
# F5cfUV8vhFTxeGOTodbwjv3GHxk4BAjKXhoHCPikkCC+tdzgCoAn+ie9Q0iSp28A
# kpXt099ByFpkCQ+4fu2+XjX6deC8mxKBKrqjNNEZDqhwuOuiG5Kw8lAzueQErmcZ
# djPm6HqnMQFvs4kAp3VMWiqMgkpjJqwB7dfffJfLcXr3+2WF8Ts181/y9LqnkGqn
# rlEjy57/dzbzTdt547j8GtKCbXmYOxUgd2a3k2sKCGBsCITtIpTjz2YsrafV84iD
# gij8M1IHvt41TNhikvWNKGxJ/5ZY2cx5G/QRbRFVYdFAR14xM45Q/XYuziQgt4if
# 6/g7WibP9d8Sqb5Mlj4HLqpPghY0AZ+aaIAHVCDCVYsLpbw7Ixk=
# =zdCl
# -----END PGP SIGNATURE-----
# gpg: Signature made Mon 18 Nov 2024 12:46:04 GMT
# gpg: using RSA key FAABE75E12917221DCFD6BB2E3E32C2CDEADC0DE
# gpg: Good signature from "Philippe Mathieu-Daudé (F4BUG) <[email protected]>"
[full]
# Primary key fingerprint: FAAB E75E 1291 7221 DCFD 6BB2 E3E3 2C2C DEAD C0DE
* tag 'hw-misc-20241118' of https://github.com/philmd/qemu:
hw/watchdog/cmsdk_apb_watchdog: Fix broken link
net: mark struct ip_header as QEMU_PACKED
hw/net/virtio-net.c: Don't assume IP length field is aligned
hw/audio/hda: fix memory leak on audio setup
Revert "hw/audio/hda: fix memory leak on audio setup"
hw/misc/mos6522: Fix bad class definition of the MOS6522 device
hw/sd/sdhci: Fix coding style
tests/qtest/migration: Fix indentations
usb-hub: Fix handling port power control messages
MAINTAINERS: Update my email address for COLO
hw/display: check frame buffer can hold blob
hw/display: factor out the scanout blob to fb conversion
hw/i386/elfboot: allocate "header" in heap
hw/misc/nrf51_rng: Don't use BIT_MASK() when we mean BIT()
vl: fix qemu_validate_options() indention
Signed-off-by: Peter Maydell <[email protected]>
Commit: 3428a3894c6fdf43bc07405090699b1de5013cfc
https://github.com/qemu/qemu/commit/3428a3894c6fdf43bc07405090699b1de5013cfc
Author: Peter Maydell <[email protected]>
Date: 2024-11-18 (Mon, 18 Nov 2024)
Changed paths:
M configure
M target/i386/kvm/hyperv-stub.c
Log Message:
-----------
Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging
* target/i386: fix compilation without CONFIG_HYPERV
* configure: improve check for execution in the source directory
# -----BEGIN PGP SIGNATURE-----
#
# iQFIBAABCAAyFiEE8TM4V0tmI4mGbHaCv/vSX3jHroMFAmc7NvAUHHBib256aW5p
# QHJlZGhhdC5jb20ACgkQv/vSX3jHroMOSQf/QXfSlvWBpu2OR6EIBVEDWnCUWyK8
# /88A/sWHCcWiD666NX7pKU5c7zzzC5x5e/ajzYriF2rNcwYhjX/MmsaQstfoWULM
# dxtLpvhWxNyfoEPIHYwAXB4/VPpm8LbIfby6kXdKZR3PQcA223qdx3ZmoTB1PI2a
# yVMkfW/+QEss9ZBzu+kUHk7BYWJ/o6o7jv6HZVtfxFV7xg17sJX/QgOZi2xmAXBj
# Z2w/97h1IWwzNpnOqc+vkDzWgqjHI+o9HWK2fQDKgpUE8vW8kJ5SgoQ/wd2BHBu7
# xGwVXw/Yoz4D/+yPZOewxhX7Ep1PBxtwCXpx4Gx7dc1Su1OBPnn5chND4w==
# =bsiH
# -----END PGP SIGNATURE-----
# gpg: Signature made Mon 18 Nov 2024 12:45:36 GMT
# gpg: using RSA key F13338574B662389866C7682BFFBD25F78C7AE83
# gpg: issuer "[email protected]"
# gpg: Good signature from "Paolo Bonzini <[email protected]>" [full]
# gpg: aka "Paolo Bonzini <[email protected]>" [full]
# Primary key fingerprint: 46F5 9FBD 57D6 12E7 BFD4 E2F7 7E15 100C CD36 69B1
# Subkey fingerprint: F133 3857 4B66 2389 866C 7682 BFFB D25F 78C7 AE83
* tag 'for-upstream' of https://gitlab.com/bonzini/qemu:
configure: Use -ef to compare paths
target/i386: hyperv: add stub for hyperv_syndbg_query_options
Signed-off-by: Peter Maydell <[email protected]>
Compare: https://github.com/qemu/qemu/compare/0fbc798e4f51...3428a3894c6f
To unsubscribe from these emails, change your notification settings at
https://github.com/qemu/qemu/settings/notifications
